Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known_data_files and a few more config files #363

Merged
merged 11 commits into from
Sep 24, 2024

Conversation

usama8800
Copy link
Contributor

@usama8800 usama8800 commented Sep 14, 2024

Adds support for programs.plasma.dataFile in rc2nix.py

@HeitorAugustoLN HeitorAugustoLN self-assigned this Sep 20, 2024
@HeitorAugustoLN HeitorAugustoLN added 0. type: enhancement New feature or request for feature 1. scope: rc2nix Related to rc2nix labels Sep 20, 2024
…evil module (nix-community#366)

This change was made to maintain consistency with other options
@magnouvean
Copy link
Collaborator

Just want to say I've tested and it seems to work fine on my end at the very least. The code looks good as well so I'd be happy to merge.

Copy link
Member

@HeitorAugustoLN HeitorAugustoLN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works flawlessy, just needs to be formatted, because of #370

script/rc2nix.py Outdated Show resolved Hide resolved
script/rc2nix.py Outdated Show resolved Hide resolved
@HeitorAugustoLN HeitorAugustoLN merged commit d3b59ae into nix-community:trunk Sep 24, 2024
1 check passed
@HeitorAugustoLN
Copy link
Member

Thanks for your contribution! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants