Add KXMLGUI support and add konsole options for toolbar customization #362
Conversation
HeitorAugustoLN
added
0. type: enhancement
There was a problem hiding this comment.
The code looks good and I've done some very limited testing and the output files look as expected.
I think reformatting with nixfmt-rfc-style makes a lot of sense. We could do this gradually every time we modify the code, or we could do it all in one pr. I think both options are fine, but I'd maybe prefer to do it all in one pr.
Also we should perhaps add kxmlgui5 to defaultResetFiles so they are reset when using overrideConfig. This will require some minor changes though as it's located in a separate directory, but still shouldn't be a lot of work.
| konsole = lib.mkOption { | ||
| type = lib.types.nullOr kxmlguiType; | ||
| default = null; | ||
| description = '' | ||
| The toolbar of Konsole. | ||
| ''; | ||
| }; | ||
| session = lib.mkOption { | ||
| type = lib.types.nullOr kxmlguiType; | ||
| default = null; | ||
| description = '' | ||
| The toolbar of Konsole sessions. | ||
| ''; |
There was a problem hiding this comment.
Some example properties could maybe be good here
| menus = lib.mkOption { | ||
| type = lib.types.listOf menuType; | ||
| description = "The menus of the menu bar."; | ||
| }; |
There was a problem hiding this comment.
Could this not just be a submodule of listOf itemType, so instead of having something like
menus = [
{
name = "name";
items = ["item1" ...];
}
]
you could have
menus."name" = ["item1" ...];
|
I think the current approach is not that good, I think I will implement something in a script for it instead. |
|
I see that. The code would maybe be better and more extensible as well. The implementation could be very similar to the write-config script. |
Closes #327
This pull request adds support for KXMLGUI configurations, adding support for Konsole shortcuts and toolbar. Additionally, the modified files have been formatted using
nixfmt-rfc-style, aligning with the upcoming adoption of this formatter as the default for Nix. Sincenixpkgs-fmthas been archived in favor ofnixfmt-rfc-style, I think we should gradually apply this formatting to other files across the project. Thoughts?