fix example #100
Closed
fix example #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should also close #57. |
|
@magnouvean I hope it's ok to ping you (or should I just wait with PRs like that?) |
|
Yeah no problem about it. I have been reworking the documentation and examples a bit in my fork at https://github.com/magnouvean/plasma-manager/tree/documentation-updates, and among the changes have been in flake.nix. There I've rewritten the flake.nix quite a lot. I think it should be ready in a few days and we do one big pr for improved documentation. Therefore I think there's not much point in fixing this right now as it probably will just be changed in a couple days anyway. I'll open a draft pr right away and we can work there directly |
|
Closing this in favour of #104 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for the errors noticed by @dvaerum in #84.
I had to update the stateversion (18.09 would have been default, but it did not compile with the old version but does with the new).
The example now works again.