Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/package-options: allow option defaults to throw #2300

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

MattSturgeon
Copy link
Member

This is often an intended behaviour, so just assume any option whose default throws is not a package-type option

Extracted from #2022

This is often an intended behaviour, so just assume any option whose
default throws is not a package-type option
@MattSturgeon
Copy link
Member Author

@Mergifyio queue

Copy link
Contributor

mergify bot commented Sep 24, 2024

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at e64c511

Copy link
Contributor

mergify bot commented Sep 24, 2024

This pull request, with head sha e64c511811559033e65d1c57b4d3df83deac7683, has been successfully merged with fast-forward by Mergify.

This pull request will be automatically closed by GitHub.

As soon as GitHub detects that the sha e64c511811559033e65d1c57b4d3df83deac7683 is part of the main branch, it will mark this pull request as merged.

It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch package_options, this means GitHub will fail to detect the merge.

@mergify mergify bot merged commit e64c511 into nix-community:main Sep 24, 2024
4 checks passed
@MattSturgeon MattSturgeon deleted the package_options branch September 24, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants