Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kitty: allow not setting shell_integration #5960

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MithicSpirit
Copy link
Contributor

Description

This allows better support for using kitty's built-in shell integration
method by setting shellIntegration.mode to null, which makes it not
be set at all in the config file and disables modification to shell
initialization scripts by default. If this is used, the user should set
settings.shell_integration instead (if shell integration is desired),
which receives no special handling.

I'm not sure whether the mode != null should just be part of the default options or if it should be forced.

Fixes #5809

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Maintainer CC

@teto

This allows better support for using kitty's built-in shell integration
method by setting `shellIntegration.mode' to `null', which makes it not
be set at all in the config file and disables modification to shell
initialization scripts by default. If this is used, the user should set
`settings.shell_integration' instead (if shell integration is desired),
which receives no special handling.
@MithicSpirit
Copy link
Contributor Author

At this rate, maybe I should just add myself as a maintainer.

@khaneliman
Copy link
Contributor

At this rate, maybe I should just add myself as a maintainer.

Thought always crosses my mind lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kitty allow not setting shell_integration=no_rc
2 participants