-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modules/services/dropbox.nix: fix dropbox service #5923
base: master
Are you sure you want to change the base?
Conversation
modules/services/dropbox.nix
Outdated
|
||
systemd.user.services.dropbox = { | ||
Unit = { Description = "dropbox"; }; | ||
|
||
Install = { WantedBy = [ "default.target" ]; }; | ||
|
||
Service = { | ||
Environment = [ "HOME=${homeBaseDir}" "DISPLAY=" ]; | ||
Environment = [ "HOME=${homeBaseDir}" "LD_LIBRARY_PATH=${pkgs.libGL}/lib/"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in the package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do I do that? Sorry this is my first contribution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ttuegel Can you help me with this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be fixed in the package
@SuperSandro2000
This has been fixed. Is this ready to be merged?
The dropbox-cli package is not well maintained and no longer works as used here. The dropbox package has more support and is currently working. As such, these changes switch the system from dropbox-cli to dropbox.
homeBaseDir = "${config.home.homeDirectory}/${baseDir}"; | ||
|
||
in { | ||
meta.maintainers = [ maintainers.eyjhb ]; | ||
meta.maintainers = [ maintainers.tph5595 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you are not in the Nixpkgs repo maintainer list, you will have to add yourself to the modules/lib/maintainers.nix
file and change this line to
meta.maintainers = [ maintainers.tph5595 ]; | |
meta.maintainers = [ hm.maintainers.tph5595 ]; |
No need to add real name if you feel uncomfortable with that, your GitHub user ID is 6002071:
$ curl -s https://api.github.com/users/tph5595 | jq .id
6002071
Description
The dropbox service does not work because it uses
dropbox-cli
and notdropbox
. This changes the service to usedropbox
only. Additionally, the old maintainer is not active (NixOS/nixpkgs#235345 (comment)) so I added myself as the maintainer.Checklist
Change is backwards compatible.
Code formatted with
./format
.Code tested through
nix-shell --pure tests -A run.all
ornix develop --ignore-environment .#all
using Flakes.Test cases updated/added. See example.
Commit messages are formatted like
Maintainer CC
@eyJhb