Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spotify-player: add support for actions #5911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Sep 29, 2024

Description

Add support for configuring actions added in the new v0.19.1 release.

@repparw

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

@repparw
Copy link

repparw commented Sep 29, 2024

test failed, seems to be order of output in the file?
don't think is relevant for the program

Actions were added in the v0.19.1 release.
@diniamo
Copy link
Contributor Author

diniamo commented Sep 29, 2024

Society if CI only ran the relevant tests

@repparw
Copy link

repparw commented Oct 4, 2024

@rycee can you have a look at this? Seems to be a quick merge I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants