Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: support simple key bindings #4599

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

arulagrawal
Copy link

@arulagrawal arulagrawal commented Oct 22, 2023

In fish shell, support simple keybinds of the form "SEQUENCE" -> COMMAND, as described in the fish docs: https://fishshell.com/docs/current/cmds/bind.html

Description

Support generating simple keybinds for fish shell. The implementation is the same as that for the aliases which existed already, however I am unsure of the escapeShellArg function. It's presence would break the 3rd test case (I included this specifically because it is listed as an example in the docs, but maybe there is a better way to handle this?

Edit: Not sure what mistake I made earlier but I'm pretty sure it works (tests passing).

This is my first time contributing to nix stuff so any pointers are appreciated.

Checklist

  • Change is backwards compatible.

  • Code formatted with ./format.

  • Code tested through nix-shell --pure tests -A run.all or nix develop --ignore-environment .#all using Flakes.

  • Test cases updated/added. See example.

  • Commit messages are formatted like

    {component}: {description}
    
    {long description}
    

    See CONTRIBUTING for more information and recent commit messages for examples.

  • If this PR adds a new module

    • Added myself as module maintainer. See example.

Copy link

stale bot commented Jan 21, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Jan 21, 2024
@stale stale bot removed the status: stale label May 8, 2024
support simple keybinds of the form "SEQUENCE" -> COMMAND,
as described in the fish docs: https://fishshell.com/docs/current/cmds/bind.html
@arulagrawal
Copy link
Author

I guess this may run afoul of the "Add only valuable options" guideline, and seeing as no one added this small option already, I don't disagree since these simple binds could easily be placed in interactiveShellInit.

@rycee (wasn't sure who else to ping)

Copy link

stale bot commented Aug 8, 2024

Thank you for your contribution! I marked this pull request as stale due to inactivity. Please read the relevant sections below before commenting.

If you are the original author of the PR

  • GitHub sometimes doesn't notify people who commented / reviewed a PR previously when you (force) push commits. If you have addressed the reviews you can officially ask for a review from those who commented to you or anyone else.
  • If it is unfinished but you plan to finish it, please mark it as a draft.
  • If you don't expect to work on it any time soon, please consider closing it with a short comment encouraging someone else to pick up your work.
  • To get things rolling again, rebase the PR against the target branch and address valid comments.

If you are not the original author of the PR

  • If you want to pick up the work on this PR, please create a new PR and indicate that it supercedes and closes this PR.

@stale stale bot added the status: stale label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant