git: add realName inside From field

We currently have no way of specifying the sender's name inside the
From field, making a patch sent through `git send-email` appear as
coming from "[email protected]".

In this commit we make this field follow the standard

    realName <email>

format.

modules/programs/git.nix

@@ -392,7 +392,7 @@ in {
           nameValuePair "sendemail.${name}" (if account.msmtp.enable then {
             smtpServer = "${pkgs.msmtp}/bin/msmtp";
             envelopeSender = "auto";
-            from = address;
+            from = "${realName} <${address}>";
           } else
             {
               smtpEncryption = if smtp.tls.enable then
@@ -407,7 +407,7 @@ in {
                 mkIf smtp.tls.enable (toString smtp.tls.certificatesFile);
               smtpServer = smtp.host;
               smtpUser = userName;
-              from = address;
+              from = "${realName} <${address}>";
             } // optionalAttrs (smtp.port != null) {
               smtpServerPort = smtp.port;
             });

tests/modules/programs/git/git-with-email-expected.conf

@@ -1,12 +1,12 @@
 [sendemail "hm-account"]
-	from = "[email protected]"
+	from = "H. M. Test Jr. <[email protected]>"
 	smtpEncryption = "tls"
 	smtpServer = "smtp.example.org"
 	smtpSslCertPath = "/etc/test/certificates.crt"
 	smtpUser = "home.manager.jr"
 
 [sendemail "[email protected]"]
-	from = "[email protected]"
+	from = "H. M. Test <[email protected]>"
 	smtpEncryption = "ssl"
 	smtpServer = "smtp.example.com"
 	smtpSslCertPath = "/etc/ssl/certs/ca-certificates.crt"

tests/modules/programs/git/git-with-email.nix

@@ -33,8 +33,8 @@ with lib;
         ./git-with-email-expected.conf
       }
 
-      assertGitConfig "[email protected]" "[email protected]"
-      assertGitConfig "sendemail.hm-account.from" "[email protected]"
+      assertGitConfig "[email protected]" "H. M. Test <[email protected]>"
+      assertGitConfig "sendemail.hm-account.from" "H. M. Test Jr. <[email protected]>"
     '';
   };
 }

tests/modules/programs/git/git-with-msmtp-expected.conf

@@ -1,13 +1,13 @@
 [sendemail "hm-account"]
-	from = "[email protected]"
+	from = "H. M. Test Jr. <[email protected]>"
 	smtpEncryption = "tls"
 	smtpServer = "smtp.example.org"
 	smtpSslCertPath = "/etc/ssl/certs/ca-certificates.crt"
 	smtpUser = "home.manager.jr"
 
 [sendemail "[email protected]"]
 	envelopeSender = "auto"
-	from = "[email protected]"
+	from = "H. M. Test <[email protected]>"
 	smtpServer = "@msmtp@/bin/msmtp"
 
 [user]

tests/modules/programs/git/git-with-msmtp.nix

@@ -7,6 +7,7 @@ with lib;
 
   config = {
     accounts.email.accounts."[email protected]".msmtp.enable = true;
+
     programs.git = {
       enable = true;
       package = pkgs.gitMinimal;
@@ -33,8 +34,8 @@ with lib;
       assertFileContent home-files/.config/git/config \
         ${./git-with-msmtp-expected.conf}
 
-      assertGitConfig "[email protected]" "[email protected]"
-      assertGitConfig "sendemail.hm-account.from" "[email protected]"
+      assertGitConfig "[email protected]" "H. M. Test <[email protected]>"
+      assertGitConfig "sendemail.hm-account.from" "H. M. Test Jr. <[email protected]>"
       assertGitConfig "[email protected]" "${pkgs.msmtp}/bin/msmtp"
       assertGitConfig "[email protected]" "auto"
     '';