feat: add create_certificate_with_sid
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usually, a SID is cumbersome to produce for a certificate, most of the time, we can reuse the leaf's certificate issuer information. `create_certificate` now takes a leaf certificate to extract the issuer information from.
baloo
reviewed
Jan 4, 2024
| pe, | ||
| certificates, | ||
| cms::signed_data::SignerIdentifier::IssuerAndSerialNumber( | ||
| cms::cert::IssuerAndSerialNumber { |
There was a problem hiding this comment.
note to self: This could be worth a impl From<&Cert> for cms::cert::IssuerAndSerialNumber
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usually, a SID is cumbersome to produce for a certificate, most of the time, we can reuse the leaf's certificate issuer information.
create_certificatenow takes a leaf certificate to extract the issuer information from.