Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RF: Upgrade nitransforms and remove workarounds #3378

Merged
merged 5 commits into from
Oct 10, 2024

Conversation

effigies
Copy link
Member

I've manually verified that load_ants_h5() can be replaced with nitransforms.manip.load() and that this does the right thing, and that using nitransforms.apply(xfm, moving, target) does indeed get me basically the same thing as ANTs.

Copy link

codecov bot commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 72.06%. Comparing base (6e6eadc) to head (7a7a623).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
fmriprep/workflows/bold/registration.py 0.00% 4 Missing ⚠️
fmriprep/utils/transforms.py 0.00% 2 Missing ⚠️
fmriprep/interfaces/resampling.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
+ Coverage   71.70%   72.06%   +0.35%     
==========================================
  Files          57       57              
  Lines        4259     4231      -28     
  Branches      640      456     -184     
==========================================
- Hits         3054     3049       -5     
+ Misses       1090     1067      -23     
  Partials      115      115              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fmriprep/workflows/bold/registration.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/registration.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/registration.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/registration.py Outdated Show resolved Hide resolved
fmriprep/workflows/bold/registration.py Outdated Show resolved Hide resolved
Co-authored-by: Chris Markiewicz <[email protected]>
@effigies effigies merged commit 52eee57 into nipreps:master Oct 10, 2024
17 of 18 checks passed
@effigies effigies deleted the rf/nitransforms24 branch October 10, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants