added spm_global function #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spm_funcs.py
Outdated
| img = nib.load(fname) # Load image | ||
| data = img.get_fdata() # Get image data | ||
|
|
||
| spm_values = np.asarray([]) # create empty array for spm values per volume |
There was a problem hiding this comment.
You can delete this line - you aren't using it.
There was a problem hiding this comment.
of course, thank you. I started a for loop then converted to a list comprehension and forgot to del. Fixing...
spm_funcs.py
Outdated
| img = nib.load(fname) # Load image | ||
| data = img.get_fdata() # Get image data | ||
|
|
||
| spm_values = np.asarray([]) # create empty array for spm values per volume |
There was a problem hiding this comment.
of course, thank you. I started a for loop then converted to a list comprehension and forgot to del. Fixing...
|
a question: I have now commited and pushed changes, is that then part of the same pull request or do I have to close this one and create a new one? |
|
You make a pull request from a branch in your fork - in this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
please accept changes to spm_func.py with changes: added code for spm_spm_global sfunction :)