2017-10-25--UPSTREAM: merge up to Jun 25, 2016 updates #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If primecoind is generating coins at the time of 'primecoind stop',
it can/will segfault:
Core was generated by `./primecoind'.
Program terminated with signal 11, Segmentation fault.
(this=0x7f3a64000d20) at prime.cpp:552
552 unsigned int nPrime = vPrimes[nPrimeSeq];
This occurs because in thread number 2, exit() gets called,
which in turns calls atexit() / on_exit() handlers. Boost registers
some handlers to free memory (OpenSSL specifically which causes the
above to result in segfaulting.)
So the fix is to stop the thread group in GenerateCoins() by telling
it to not generate coins, which results in a clean process exit.
The above crash can be reproduced by running primecoind in coin
generation mode, and stopping it with 'primecoind stop' under
Ubuntu 13.04, latest apt-get update / apt-get upgrade -y.
(Tips welcome, ARhURiSGy9NMiXQr2Q9h3AL8qPntcsSKkF - it will make up
for the orphans I'm seeing :-( )
The boost equivilent of pthread_cond_signal would be better than spinning in a loop, but I don't know enough about boost to implement that :>
Graceful shutdown of miner threads (David L. Unger)
Update Qt text message in ui forms (geeknik)
Miner create new block at most once every 10 seconds
Update Bitcoin references to Primecoin in the locale/translation files (geeknik)
…pping if desired. Probably makes sense for nSieveRoundOptimal as well - but I didn't have time to test.
Primecoin: Add prime.h to qt project file Primecoin: Set nMaxSieveSize slightly easier to configure (joebauers)
…cords'
Show primorial form of prime chain origin in 'listprimerecords'
Primecoin: Update locale translation text (geeknik)
If enabled, enforce v0.2 protocol on getwork and submitblock
If enabled, enforce v0.2 protocol on getwork and submitblock
Without network discovery addresses broadcasted by peers
are not recorded by address manager, causing connection
issues for no listen mode (-listen=0).
Without network discovery addresses broadcasted by peers
are not recorded by address manager, causing connection
issues for no listen mode (-listen=0).
New versions of OpenSSL will reject non-canonical DER signatures. However, it'll happily decode them. Decode then re-encode before verification in order to ensure that it is properly consumed. Github-Pull: bitcoin#5634 Rebased-From: 488ed32
Github-Pull: bitcoin#5634 Rebased-From: 8dccba6
…t when receiving a new sync-checkpoint.
Fixes building in newer linux distros Based on: bitcoin#6113
* fix missing bignum field when spv wallet sync data. * modify bitcoin to primecoin someplace * add changelist file
Fixes building in newer linux distros Based on: bitcoin#6113
refine checkpoint code, and add block header check when load from disk (cherry-picked from 5b4cb77)
(cherry-picked from 6137ee0)
(cherry-picked from 901a338)
(cherry-picked from 5dbe3c1)
1.modify bitcoin to primecoin someplace 2.Fixed an issue where the menu could not be seen when the program started 3.Adds verification of password length 4.Fixed some UI logic errors 5.Fixed a problem with English display in Chinese version (cherry-picked from 76606fb)
Update gitian builder README; fix repository address
* Update mainnet and testnet dnsseed
* Update client version to 0.1.3
Move out of main.h to improve compile times and add documentation for what the methods do.
…ance problems caused by Primecoin's very long blockchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.