Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: nkError semIdentVis/IdentWithPragma #767

Draft
wants to merge 5 commits into
base: devel
Choose a base branch
from

Commits on Jun 17, 2023

  1. part way through

    going to refactor:
    - generate one `nkError` node
    - contains a set of issue markers
    - can generate more than one diagnostic message
    saem committed Jun 17, 2023
    Configuration menu
    Copy the full SHA
    d4df5ac View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2023

  1. new versions of semIdentVis/IdentWithPragma

    Still not happy with the API and a few things are vague, to think about:
    - `semIdentVis` muddles AST sem, and evaling a symbol constructor
    - symbol construction wants to succeed regardless (for nimsuggest/check)
    - AST needs to capture the errors (for `sempass2` output)
    - how to keep sem idempotent with pragma/export AST sticking around?
      - maybe `semAfterMacroCall` can wrap output in `nkError`?
    - the getSym/Recover proc feel off
    
    Teasing this apart feels unnecessarily difficult, but perhaps it'll have
    large knockon effects to various parts of sem. Especially when it comes
    to clarifying semanticizing AST, symbolic, and type parts of sem.
    saem committed Jun 18, 2023
    Configuration menu
    Copy the full SHA
    76b6595 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    70d5c78 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2023

  1. Configuration menu
    Copy the full SHA
    6ec2b98 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. draft attempts at vairous approaches

    will clean-up later, but one takeaway is symbol producing `newSymG` that
    places errors in the `.ast` field. That seems potentially cleaner.
    saem committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    92ffc05 View commit details
    Browse the repository at this point in the history