sem: fix error propagation for tuple construction #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= * fix errors in anonymous tuple constructions not being propagated * fix the error for colon expressions in anonymous tuple constructions being "invalid expression" instead of "named expression not allowed here" Details ======= * properly propagate errors from element expressions * don't analyze `nkExprColonExpr` as a normal expression * don't modify input AST * skip tuple type constructor analysis if any of the element expressions is erroneous
zerbina
added
bug
saem
approved these changes
Aug 7, 2024
| tupExp[i] = c.config.newError(tupExp[i], | ||
| PAstDiag(kind: adSemNamedExprNotAllowed)) | ||
| elif isTupleType != (tupExp[i].typ.kind == tyTypeDesc): | ||
| if isTupleType != (tupExp[i].typ.kind == tyTypeDesc): |
There was a problem hiding this comment.
Do we want to allow this in a compile time context?
There was a problem hiding this comment.
At some point, yes, but only very little of the compiler is aware of tyTypeDesc's additional meaning of "fist-class type value", so I don't think it's realistic right now.
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
being "invalid expression" instead of "named expression not allowed
here"
Details
nkExprColonExpras a normal expressionexpressions is erroneous