-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix C compilation errors with closures and nested types #1397
Merged
chore-runner
merged 2 commits into
nim-works:devel
from
zerbina:unique-hash-for-all-object-types
Aug 4, 2024
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
discard """ | ||
description: ''' | ||
Ensure that separate hooks are created for ``ref T`` types where T are non- | ||
top-level object types sharing the exact same name and shape | ||
''' | ||
targets: "c js vm" | ||
""" | ||
|
||
# XXX: this currently relies on the backend C compiler complaining. Eventually, | ||
# the test should inspect the MIR output and make sure two different | ||
# destroy hooks are used | ||
|
||
block: | ||
type Nested = object | ||
|
||
var a = (ref Nested)() | ||
|
||
block: | ||
type Nested = object | ||
|
||
var b = (ref Nested)() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
discard """ | ||
description: ''' | ||
Ensure that separate hooks are created for ``ref T`` types where T are non- | ||
top-level object types sharing the exact same name and shape | ||
''' | ||
targets: "c js vm" | ||
""" | ||
|
||
# XXX: this currently relies on the backend C compiler complaining. Eventually, | ||
# the test should inspect the MIR output and make sure two different | ||
# destroy hooks are used | ||
|
||
# for this test, both procedures must: | ||
# * share the same user-provided name | ||
# * create an anonymous environment object with the exact same shape and field | ||
# names | ||
|
||
proc outer(x: int) = | ||
var x = 1 | ||
proc inner() = | ||
x = 2 | ||
inner() | ||
|
||
proc outer(x: float) = | ||
var x = 1 | ||
proc inner() = | ||
x = 2 | ||
inner() | ||
|
||
outer(1) | ||
outer(1.0) |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the top level check wouldn't it make sense to check if the owning symbol is not an
skModule
, or would that be a problem for generic instantiations?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing whether the owner is an
skModule
symbol wouldn't be able to detect theNested
type fromtseparate_hooks1.nim
(where the owner is a module symbol).sem
marks such types' symbols with thesfGenSym
at the moment, so that they can be detected here. The only proper solution to this mess is getting rid ofsighashes
, really.