fix a compiler crash with .varargs proc types
#1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Fix the compiler crashing when a non-closure `proc` type with C-style varargs is used somewhere. Only the C backend was affected. Details ======= * `mirtypes.callConv` didn't consider the `x` field storing a boolean value in the most-significant bit, resulting in range defect * the integer value is now properly masked before converting it to a `TCallingConvention` enum value
zerbina
added
bug
saem
approved these changes
Aug 4, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix the compiler crashing when a non-closure
proctype with C-stylevarargs is used somewhere. Only the C backend was affected.
Fixes #1394.
Details
mirtypes.callConvdidn't consider thexfield storing a booleanvalue in the most-significant bit, resulting in range defect
TCallingConventionenum value