fix C codegen regression with closures #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ------- Fix explicit or implicit creation of a closure leading to the C compiler errors when using strict(er) C compilers. Details ------- * when lowering the closure types, use a `tkProc` type with `ccClosure` calling convention * using a `ccNimCall` type with an additional `void` parameter meant that `cgen` placed the result type (in case of RVO) *after* the environment type, which is incorrect and doesn't match the signature of closure procedures * C compilers that require proper typing for pointer assignments rightfully reported an error in this case
zerbina
added
bug
saem
approved these changes
Jul 31, 2024
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix explicit or implicit creation of a closure leading to C
compiler errors when using strict(er) C compilers.
Details
tkProctype withccClosurecalling convention
ccNimCalltype with an additionalvoidparameter meantthat
cgenplaced the result type (in case of RVO) after theenvironment type, which is incorrect and doesn't match the signature
of closure procedures
rightfully reported an error in this case