Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sem: varargs now have and conform to a specification #1207

Open
wants to merge 20 commits into
base: devel
Choose a base branch
from
Open

sem: varargs now have and conform to a specification #1207

wants to merge 20 commits into from

Conversation

saem
Copy link
Collaborator

@saem saem commented Feb 25, 2024

Summary

  • created a battery of tests specifying vararg parameters and to a lesser extent the pragma
  • updated the implementation for varargs argument and parameter handling to conform to the aforementioned tests
  • updated the docs to describe the latest behaviour and indicate future direction

Details

  • info that couldn't fit into the summary
  • relevant details; tricky parts
  • anything else

Notes for Reviewers

  • the plan for this PR is to merge in tests and the rework of sigmatch in one go
    • reason for doing both simultaneously is because the spec itself needs to be vetted through implementing
  • created initial as a non-draft PR to ensure the existing tests/knownIssues are at least green in CI
  • rough plan, in case you have feedback on the approach:
    • get initial tests in place
    • add docs to tests clarifying the intention from the notes remaining in tvarargs
    • initial revision of docs (manual.rst) to indicate new behaviour and future direction
    • rewrite sigmatch.matchesAux which contains the parameter handling
      - [ ] any related updates/changes
    • write a proper PR title and message

@saem
test varargs[untyped]
ba0ee1c 
- parameter passing
- typed ast construction
@saem
varargs without conversion precede those with
1474316 
also rename/relocate tests to more appropriate location
@saem
fix typo in test
6734a36
@saem
fix bad style (needless newlines)
ffabd7f
@saem
style clean-up for varargs + converter test
1c570f1
@saem
clean-up varargs with polymorphic args tests
511438d 
- use blocks to document each test
- reorder and group tests more logically
- note tests that should work with `knownIssue` comments
@saem
add comprehensive varargs test sketch and plan
3e28fc9 
- sketch of all missing tests identified thus far
- plan for test coverage
- inventory of existing tests
- document questions and answers for future and current direction

This will be used to create the initial test spec for varargs.
@saem
create basic varargs tests
99d22dd 
- relatively fine grained split of knownIssues for easier fixing
- cross-reference knownIssues between parent and knownIssue tests
- remove corresponding sketch tests from `tvarargs`
- disable `tvarargs` so the `lang_callable/varags` category can be run
@saem
add a non-ast-typed varargs conversions tests
1840558 
remove corresponding tests from tvarargs.
@saem
varargs non-ast types range and widening tests
fa6b706
@saem
varargs argument parsing is entirely broken
3416e8e 
until it's fixed going to be marking lots of tests as known issue
@saem
add generic properties tests
c189ca2 
- ensure varargs parameter is inferrable
- add tests to disallow type parameter being set to varargs
@saem
clean-up non-ast varargs tests
5a7c560
@saem
add overload resolution tests
ab9d07d
@saem
add untyped varargs tests
c4e80d2
@saem
clean-up migrated tests from tvarargs
9d07608
@saem
fix untyped tests
cecc7cc
@saem
add varargs[typed] tests
1aedcfe
@saem
add {.varargs.} test
b59ee3e
@saem
updated tvarargst, all tests moved out
4447e88
@saem saem added spec Specification tests edit or formal specification required. test Add or improve tests compiler/sem Related to semantic-analysis system of the compiler language-design Language design syntax, semantics, types, statics and dynamics. labels Feb 25, 2024
@zerbina zerbina mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
compiler/sem Related to semantic-analysis system of the compiler language-design Language design syntax, semantics, types, statics and dynamics. spec Specification tests edit or formal specification required. test Add or improve tests
Projects
None yet
Milestone
Semantic analysis phase refactoring
Development

Successfully merging this pull request may close these issues.
1 participant
@saem