Implement URI generation for named routes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcobucci
force-pushed
the
route-generation
branch
from
fb23c9d
to
a389f4b
Compare
lcobucci
force-pushed
the
route-generation
branch
from
a389f4b
to
4b60e45
Compare
Lock file operations: 0 installs, 2 updates, 0 removals - Upgrading phpstan/phpstan (1.10.57 => 1.10.58) - Upgrading seld/jsonlint (1.10.1 => 1.10.2) Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
This allows us to reuse that parameters to introduce the URI generation component. Signed-off-by: Luís Cobucci <[email protected]>
This allows users to easily handle exceptions coming from this library. Signed-off-by: Luís Cobucci <[email protected]>
This introduces the ability to create URIs from the configured routes, following the same semantics of route dispatching when it comes to URL encoding (it needs to be handled by the user of the library). Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
This allows them to evolve separately. Signed-off-by: Luís Cobucci <[email protected]>
Signed-off-by: Luís Cobucci <[email protected]>
This enables the retrieval of named routes and URI generation from the main library configuration. Signed-off-by: Luís Cobucci <[email protected]>
lcobucci
force-pushed
the
route-generation
branch
from
4b60e45
to
e24b7c8
Compare
Signed-off-by: Luís Cobucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Fixes #66
This is an alternative implementation for #270, leveraging extra parameters for configuring things instead of following conventions around the handler.
The route generation process is a copy of https://github.com/mezzio/mezzio-fastroute/blob/3.12.x/src/FastRouteRouter.php#L248 (created by @weierophinney) with minor changes.
I still need to:
The main arguments for following this approach are: