Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Submodules - Fixes Xcode 16 slow build plus other updates #424

Merged
merged 9 commits into from
Oct 8, 2024

Conversation

marionbarker
Copy link
Contributor

Main Goal

The primary item fixed in this PR is Issue #423.

Added updates

In addition, pick up other submodule fixes that are in the loopandlearn/submodule:trio branches but not yet added to Nightscout/Trio:dev workspace.

Information for reviewers.

  • Most of these changes are obvious from the notes below
  • LoopKit may be confusing
    • In addition to the Xcode 16 build speed up change (the pxbproj file) there are two other files modified that are only used by Loop
      • fix an Export Critical logs error
      • fix an error when rearranging Overrides on the Loop screen
  • LibreTransmitter
    • In addition to the Xcode 16 build speed up change (the pxbproj file, another modification was brought in to prevent notification when not enabled

Summary of submodules changed with this PR:

Submodules changed:

* CGMBLEKit 15af9cf...b786e8b (1):
  > Merge branch 'LoopKit:dev' into trio

* G7SensorKit b5e992e...2be3eb2 (1):
  > Add ONE+ to the display name (#28)

* LibreTransmitter fb83de0...0848e26 (3):
  > Merge pull request #3 from dnzxy/module-verify
  > Merge branch 'LoopKit:main' into trio
  > Merge pull request #2 from loopandlearn/loopkit-pr-15

* LoopKit 6d9b19ab...a5c1d668 (2):
  > Merge pull request #3 from dnzxy/module-verify
  > Merge branch 'LoopKit:dev' into trio

* OmniBLE e398345...4ad8117 (2):
  > Merge pull request #131 from dnzxy/module-verify
  > Merge pull request #128 from loopandlearn/fix/deactivate-sideways-pull

* OmniKit 849dc7a...01bc598 (2):
  > Merge pull request #40 from dnzxy/module-verify
  > Merge pull request #39 from loopandlearn/fix/deactivate-sideways-pull

@marionbarker
Copy link
Contributor Author

Notes about most recent commit:

  • The LoopKit/LibreTransmitter:main branch was updated
  • The loopandlearn/LibreTransmitter:trio branch was updated to match
  • The SHA for the trio branch updated because of the merge commit
  • No change to the code with this commit - housekeeping task to add the update

@marionbarker
Copy link
Contributor Author

These updates to the SHA for the LoopKit submodules aligns with the version for these submodules just released in Loop 3.4.3.

Since last comment, I added commits so code matches the LoopKit/LibreTransmitter:main branch and LoopKit/LoopKit:dev branch and SHA match the values found in loopandlearn/*:trio branch.

This latest update for the LoopKit submodule is improvement in visibility for CheckmarkListItems, especially important for dark mode with iOS 18 devices.

Graphic shows screen from previous code on left and updated code on the right.

original_revised_dark

Copy link
Contributor

@bjornoleh bjornoleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds to sim, can confirm G6+ and G7+ text is updated, and otherwise involves very few changes to code.

No uncommitted changes after building.

@bjornoleh bjornoleh linked an issue Oct 8, 2024 that may be closed by this pull request
@dnzxy
Copy link
Contributor

dnzxy commented Oct 8, 2024

Merging with 2 approvals.

@dnzxy dnzxy merged commit c5e7bb6 into nightscout:dev Oct 8, 2024
1 check passed
@marionbarker marionbarker mentioned this pull request Oct 13, 2024
This was referenced Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename "G6" -> "G6 / ONE" and "G7" -> "G7 / ONE+"
3 participants