update submodules OmniXXX: fix rare Insert Cannula error when cannula is already inserted #388
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marionbarker
requested review from
dnzxy,
bjornoleh,
MikePlante1,
aug0211,
AndreasStokholm,
Sjoerd-Bo3 and
t1dude
as code owners
AndreasStokholm
approved these changes
Aug 20, 2024
dnzxy
approved these changes
Aug 24, 2024
MikePlante1
approved these changes
Aug 25, 2024
mountrcg
pushed a commit
to mountrcg/Trio
that referenced
this pull request
Sep 11, 2024
…aired update submodules OmniXXX: fix rare Insert Cannula error when cannula is already inserted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects the rare event reported in Issue #380.
The code for each submodule, OmniBLE and OmniKit, was updated for InsertCannulaViewModel. Return success if podAlreadyPaired is true (which only happens when cannula was successfully inserted and pod has reached pod state 8). In addition, the Preview in InsertCannulaView was updated so it could be used to test the fix.
This brings in code changes from