Skip to content

Commit

Permalink
fix(Dockerfile): Switch from scratch to distroless image (#67)
Browse files Browse the repository at this point in the history
Currently the docker image is not really working as we're missing certs
to run HTTP requests.
We could add them manually, installing with apk and then copying, but
it'll be easier to just use
[distroless](https://github.com/GoogleContainerTools/distroless) image
which comes all-inclusive.
  • Loading branch information
nieomylnieja authored Jun 1, 2024
1 parent a746974 commit c7faae7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ RUN CGO_ENABLED=0 go build \
-o /artifacts/go-libyear \
"${PWD}/cmd/go-libyear"

FROM scratch
FROM gcr.io/distroless/static-debian12

# https://github.com/opencontainers/image-spec/blob/main/annotations.md
LABEL org.opencontainers.image.authors="nieomylnieja"
Expand Down
1 change: 1 addition & 0 deletions cspell.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ ignorePaths:
- bin/**
- test/**
words:
- distroless
- endef
- gobin
- gofumpt
Expand Down

0 comments on commit c7faae7

Please sign in to comment.