Disable compression by default #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's the use case for disabling compression? |
|
To be honest, I have no memory of creating this, sorry. My patch is also bad. I think I was maybe creating it for https://github.com/zoidbergwill/bazel-remote/blob/master/.github/main.workflow I originally thought it was for bazelbuild/rules_docker#1795 I think I was just trying to upload a non compressed binary, so it was easier for things to just download a binary, chmod +x it, and then run it, but gunzipping it isn't exactly difficult to do in that list of commands too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We could make this configurable with an env var or something?
Also maybe we should use a variable for
${PROJECT_NAME}${EXT}, if we're using it in multiple places now.