add logger which doesn't break json parsing #175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compatible url plumbing
KristopherPaulsen
force-pushed
the
kc/hotfix-remove-println-which-breaks-json-parsing
branch
from
7afea35
to
76983a1
Compare
KristopherPaulsen
deleted the
kc/hotfix-remove-println-which-breaks-json-parsing
branch
swalx
pushed a commit
to swalx/ngrok-go
that referenced
this pull request
Jul 24, 2024
This was referenced Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
println breaks e2e which assumes json log output