Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating installation instructions with Win 7/8 warning. #601

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

salilsub
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Feb 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ngrok-docs ✅ Ready (Inspect) Visit Preview Jun 5, 2024 4:58pm

@@ -39,7 +39,7 @@ curl -s https://ngrok-agent.s3.amazonaws.com/ngrok.asc | \
choco install ngrok
```

Run this in an Administrator Command Prompt.
Run this in an Administrator Command Prompt. Version 3.6.0+ require Windows 10 or higher. If you are using Windows 7 or 8, 3.5.0 is the last supported version of the ngrok agent.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't feel like it needs to be in the getting started guide. can we add it to the v2 - v3 upgrade guide instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if v2-v3 upgrade guide makes sense. There are multiple versions of v3 which work (3.2.x-3.5.0). This is the page where the install link points to (other than the downloads page)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@russorat any thoughts on the above?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, i think https://ngrok.com/docs/agent/#install makes more sense.

@salilsub salilsub requested a review from russorat March 29, 2024 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants