Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created shared readme and adjusted publishing fields. #31

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Created shared readme and adjusted publishing fields. #31

merged 3 commits into from
Sep 11, 2023

Conversation

zaowang-ms
Copy link
Collaborator

No description provided.

@zaowang-ms zaowang-ms requested a review from ornj August 23, 2023 07:15
@zaowang-ms
Copy link
Collaborator Author

zaowang-ms commented Aug 23, 2023 •
edited
Loading

Hi @ornj @amudukutore , this is the PR of creating a shared readme of this repo and added some project descriptions and fields in the task.json and vss-extension.json. Please note that the descriptions would appear in Visual Studio Maketplace. It would worthwhile taking a look and let me know if there is anything we need to adjust before publishing. Thanks for your time on this!

@zaowang-ms zaowang-ms self-assigned this Aug 23, 2023
@zaowang-ms zaowang-ms added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 23, 2023
@zaowang-ms
Copy link
Collaborator Author

Hi @ornj @amudukutore , muchly appreciated if these pre-release notes and json changes can be reviewed. After that, we are expecting this to be released to marketplace privately first, and then if it's all good, we will go public.

amudukutore
amudukutore approved these changes Sep 8, 2023
View reviewed changes
Copy link
Contributor

@amudukutore amudukutore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I couldn't tell what tests you had run to validate thie Azure Pipeline workflow but am assuming you have tested these. Thank you for making these changes.

@zaowang-ms zaowang-ms merged commit e16fa89 into main Sep 11, 2023
2 checks passed
@zaowang-ms zaowang-ms deleted the zaowang/creating-shared-readme-and-release-json branch September 11, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amudukutore amudukutore amudukutore approved these changes

@ornj ornj Awaiting requested review from ornj

Assignees

@zaowang-ms zaowang-ms

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zaowang-ms @amudukutore