chore: remove legacy upload codepath #2580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this seems to fix the build errors I was seeing, and necessitates a small code change
Add a test for fetching filecoin deal info from w3up. This is definitely not my best work - ideally we'd abstract this w3up mocking logic in a way that makes it less stateful, but I'm hesitant to do that when we will likely not be making many changes here in the future.
this broke existing tests because it was returning w3up deals in all situations
plus feature flag and related tests
abstract w3up mocking a bit and use it in more places
Deploying nft-storage with
|
| Latest commit: |
af174d8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f0c40a68.nft-storage-1at.pages.dev |
| Branch Preview URL: | https://feat-cleanup-w3up-feature-fl.nft-storage-1at.pages.dev |
vasco-santos
approved these changes
Apr 15, 2024
There was a problem hiding this comment.
LGTM
Not sure if you are going for a second PR to remove linkdex, but I think we should/could also remove https://github.com/nftstorage/nft.storage/blob/feat/cleanup-w3up-feature-flag/packages/api/src/routes/nfts-upload.js#L219-L222
I think that once we write to R2 only that will fail, but I am not super aware on how linkdex is built
travis
pushed a commit
that referenced
this pull request
Apr 17, 2024
🤖 I have created a release *beep* *boop* --- ## [4.8.0](api-v4.7.0...api-v4.8.0) (2024-04-17) ### Features * show deal info from w3up ([#2573](#2573)) ([766a7c1](766a7c1)) ### Bug Fixes * more logging of upload get fail ([#2593](#2593)) ([35cc344](35cc344)) * one more typo ([de5582e](de5582e)) ### Other Changes * more deals get debugging ([#2594](#2594)) ([36a26f1](36a26f1)) * remove debugging ([#2595](#2595)) ([3dc7916](3dc7916)) * remove legacy upload codepath ([#2580](#2580)) ([88c05a9](88c05a9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plus feature flag and related tests