Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template: add option to exclude the workflows directory from pipeline template #3171

Closed
wants to merge 1 commit into from
Closed

Template: add option to exclude the workflows directory from pipeline template #3171

wants to merge 1 commit into from

Conversation

mirpedrol
Copy link
Member

mashehu
mashehu approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@mashehu mashehu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbh I think this adds too much complexity/redundancy for too little gain. (I thought we had concluded that we don't need to go so minimal). But since you have done the work, I guess we can add it... 🙂
How do we make sure the code here stays in sync with the code in workflows/pipeline.nf?

@mirpedrol
Copy link
Member Author

I think this adds too much complexity/redundancy

I agree. Let's keep this feature out. Closing this PR for now 🙂

@mirpedrol mirpedrol closed this Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mashehu mashehu mashehu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mirpedrol @mashehu