Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting: Remove 'defaults' from conda environment.yml file. #3029

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Linting: Remove 'defaults' from conda environment.yml file. #3029

merged 6 commits into from
Aug 23, 2024

Conversation

ewels
Copy link
Member

@ewels ewels commented Jun 19, 2024

See nf-core/modules#5829

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels ewels mentioned this pull request Jun 19, 2024
Closed
JoseEspinosa
JoseEspinosa requested changes Jul 19, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it also be removed from here?
Otherwise, looks good to me!

@edmundmiller
Copy link
Contributor

@JoseEspinosa Good catch!

@mirpedrol
Copy link
Member

Should it also be removed from here?

Done with b2336ad

JoseEspinosa
JoseEspinosa approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mirpedrol LGTM!

@mirpedrol mirpedrol mentioned this pull request Aug 23, 2024
Merged
@mirpedrol mirpedrol mentioned this pull request Aug 23, 2024
Merged
@mirpedrol mirpedrol merged commit 557fe91 into nf-core:dev Aug 23, 2024
77 checks passed
@ewels ewels deleted the module-conda-env-remove-defaults branch August 23, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

@JoseEspinosa JoseEspinosa JoseEspinosa approved these changes

@edmundmiller edmundmiller edmundmiller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ewels @edmundmiller @mirpedrol @maxulysse @JoseEspinosa @nf-core-bot