Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow integer sample names #1421

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

idot
Copy link

@idot idot commented Oct 18, 2024

int was not allowed as sample name anymore (since 3.16.0)
Validation of file failed:
-> Entry 1: Error for field 'sample' (298098): Sample name must be provided and cannot contain spaces

PR checklist

  • [*] This comment contains a description of changes (with reason).

  • CHANGELOG.md is updated.

 Validation of file failed:
        -> Entry 1: Error for field 'sample' (298098): Sample name must be provided and cannot contain spaces
Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @idot,

It looks like this pull-request is has been made against the idot/rnaseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the idot/rnaseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@idot idot changed the base branch from master to dev October 18, 2024 11:45
@idot
Copy link
Author

idot commented Oct 18, 2024

fixes #1419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant