Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.2.0 #580

Merged
merged 165 commits into from
Sep 13, 2024
Merged

Release 2.2.0 #580

merged 165 commits into from
Sep 13, 2024

Conversation

ramprasadn
Copy link
Collaborator

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Resolve issues that cropped up when aligner and mt_aligner were different
Add option to generate csi index for managed variants
Change platform description and update vcf2cytosure conditional
@ramprasadn ramprasadn marked this pull request as ready for review September 13, 2024 12:07
Copy link
Contributor

@rannick rannick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@peterpru peterpru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@fellen31 fellen31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Just some small stuff!

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
conf/modules/prepare_references.config Outdated Show resolved Hide resolved
docs/output.md Outdated Show resolved Hide resolved
docs/usage.md Outdated Show resolved Hide resolved
nextflow_schema.json Outdated Show resolved Hide resolved
subworkflows/local/align.nf Outdated Show resolved Hide resolved
@@ -28,7 +28,8 @@ workflow ANNOTATE_GENOME_SNVS {
analysis_type // string: [mandatory] 'wgs' or 'wes'
ch_cadd_header // channel: [mandatory] [ path(txt) ]
ch_cadd_resources // channel: [mandatory] [ path(annotation) ]
ch_vcfanno_resources // channel: [mandatory] [ path(resources) ]
ch_vcfanno_extra // channel: [mandatory] [ [path(vcf),path(index)] ]
ch_vcfanno_resources // channel: [mandatory] [ [path(vcf),path(index),...] ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does ... mean?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That it contains more than one vcf and index 😅

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about [ path(vcfs), path(indices) ]? 😁

Copy link
Contributor

@fellen31 fellen31 Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still one list of multiple vcfs [ meta, [ vcf1, vcf2, vcf ], [tbi1, tbi2, tbi3] ]? and not [ meta, vcf1, tbi1 , vc2, tbi2 , etc... ] or something?

Copy link
Collaborator Author

@ramprasadn ramprasadn Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I never paid attention to this haha. 😅 How about [path(vcf1),path(index1),...,path(vcfn),path(indexn)]?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.. Its just a list containing paths and indices.. They are not grouped in any way :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I misunderstood, I edited my comment above.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. then I guess just ... is fine!

Comment on lines 22 to 24
ch_vcfanno_extra // channel: [mandatory] [ [path(vcf),path(index).....] ]
ch_vcfanno_lua // channel: [mandatory] [ path(lua) ]
ch_vcfanno_resources // channel: [mandatory] [ [path(vcf),path(index),.....] ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@ramprasadn ramprasadn merged commit fa61a65 into master Sep 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants