Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proovframe/fix module #6800

Merged
merged 3 commits into from
Oct 18, 2024
Merged

proovframe/fix module #6800

merged 3 commits into from
Oct 18, 2024

Conversation

vagkaratzas
Copy link
Contributor

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

luisas
luisas approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@luisas luisas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor comment about the version, otherwise LGTM!

modules/nf-core/proovframe/fix/main.nf Outdated
'biocontainers/proovframe:0.9.7--hdfd78af_1' }"

input:
tuple val(meta), path(fa)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tuple val(meta), path(fa)
tuple val(meta) , path(fa)

modules/nf-core/proovframe/fix/main.nf Outdated

cat <<-END_VERSIONS > versions.yml
"${task.process}":
proovframe: 0.9.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be extracted from the tool directly, something like:

modules/modules/nf-core/fastqc/main.nf

Line 49 in cb08035

fastqc: \$( fastqc --version | sed '/FastQC v/!d; s/.*v//' )

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried really hard to make that happen..but really couldn't figure out a way..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok think I found a way, brb :P

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it for the proovframe/map module as well

modules/nf-core/proovframe/fix/main.nf Outdated

cat <<-END_VERSIONS > versions.yml
"${task.process}":
proovframe: 0.9.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@vagkaratzas vagkaratzas added this pull request to the merge queue Oct 18, 2024
Merged via the queue into nf-core:master with commit a591752 Oct 18, 2024
16 checks passed
@vagkaratzas vagkaratzas deleted the proovframe/fix branch October 18, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luisas luisas luisas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vagkaratzas @luisas