Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from oras to https in phantompeakqualtools module #6711

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Switch from oras to https in phantompeakqualtools module #6711

merged 1 commit into from
Sep 30, 2024

Conversation

JoseEspinosa
Copy link
Member

Do not use oras in phantompeakqualtools module.

PR checklist

  • This comment contains a description of changes (with reason).
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@JoseEspinosa JoseEspinosa added this pull request to the merge queue Sep 30, 2024
@JoseEspinosa
Copy link
Member Author

Thanks @nvnieuwk !

Merged via the queue into nf-core:master with commit ec48f56 Sep 30, 2024
12 checks passed
@JoseEspinosa JoseEspinosa deleted the rm_oras_phantompeakqualtools branch September 30, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvnieuwk nvnieuwk nvnieuwk approved these changes

@drpatelh drpatelh Awaiting requested review from drpatelh

@edmundmiller edmundmiller Awaiting requested review from edmundmiller

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JoseEspinosa @nvnieuwk