Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umitools prepareforrsem #4897

Merged
merged 12 commits into from
Feb 13, 2024
Merged

Umitools prepareforrsem #4897

merged 12 commits into from
Feb 13, 2024

Conversation

pinin4fjords
Copy link
Member

Adding UMI tools' prepare for rsem script. This will be a native command in the next release of UMI tools, but for now I'm bundling the python with the module as a template.

See:

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords requested a review from a team as a code owner February 12, 2024 17:00
@pinin4fjords pinin4fjords requested review from Joon-Klaps and removed request for a team February 12, 2024 17:00
Copy link
Member

@maxulysse maxulysse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect

@pinin4fjords
Copy link
Member Author

Thanks @maxulysse !

@pinin4fjords pinin4fjords added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 44e0ab0 Feb 13, 2024
11 checks passed
@pinin4fjords pinin4fjords deleted the umitools_prepareforrsem branch February 13, 2024 10:41
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
* Add umitools/prepareforrsem

* Remove trailing newlines

* Fix software env

* appease eclint

* fix linting

* fix comment

* Don't snapshot python version

* Readd snapshot file

* Apply suggestions from code review

Co-authored-by: Maxime U Garcia <[email protected]>

---------

Co-authored-by: Maxime U Garcia <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Add umitools/prepareforrsem

* Remove trailing newlines

* Fix software env

* appease eclint

* fix linting

* fix comment

* Don't snapshot python version

* Readd snapshot file

* Apply suggestions from code review

Co-authored-by: Maxime U Garcia <[email protected]>

---------

Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants