-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Summarizedexperiment module from rnaseq workflow #4890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinin4fjords
requested review from
vagkaratzas
and removed request for
a team
February 9, 2024 14:12
pinin4fjords
changed the title
Migrate Summarizedexperiment modules from rnaseq workflow
Migrate Summarizedexperiment module from rnaseq workflow
Feb 9, 2024
maxulysse
approved these changes
Feb 9, 2024
Thanks @maxulysse ! |
jch-13
pushed a commit
to jch-13/modules
that referenced
this pull request
Mar 19, 2024
* tx2gene should add column names * Finalise summarized experiment * tx2gene should put column names on its output * tx2gene has column ids now * Temporarily repoint test data * Fix linting issues * Try to appease eclint * finish appeasing ecling * Remove rogue g from tidying up line endings * Remove rogue g from tidying up line endings * Update test_data.config
jennylsmith
pushed a commit
to RSC-RP/modules
that referenced
this pull request
Mar 20, 2024
* tx2gene should add column names * Finalise summarized experiment * tx2gene should put column names on its output * tx2gene has column ids now * Temporarily repoint test data * Fix linting issues * Try to appease eclint * finish appeasing ecling * Remove rogue g from tidying up line endings * Remove rogue g from tidying up line endings * Update test_data.config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fix tx2gene so its tables have column headers and deal with fallout of that.
Will need a merge of the test data nf-core/test-datasets#1093
PR checklist
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware