Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update antismash/antismashlite to 7.1.0 #4888

Merged
merged 10 commits into from
Feb 11, 2024
Merged

Update antismash/antismashlite to 7.1.0 #4888

merged 10 commits into from
Feb 11, 2024

Conversation

jasmezz
Copy link
Contributor

@jasmezz jasmezz commented Feb 9, 2024

This updates antismash/antismashlite to 7.1.0 and migrates to nf-test.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@jasmezz jasmezz requested a review from a team as a code owner February 9, 2024 13:53
@jasmezz jasmezz requested review from koenbossers and removed request for a team February 9, 2024 13:53
@jasmezz
Copy link
Contributor Author

jasmezz commented Feb 11, 2024

Thank you @jfy133 🎉

@jasmezz jasmezz added this pull request to the merge queue Feb 11, 2024
Merged via the queue into nf-core:master with commit 1c78323 Feb 11, 2024
11 checks passed
@jasmezz jasmezz deleted the update_antismash-run branch February 11, 2024 09:20
jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
@jasmezz @jch-13
Update antismash/antismashlite to 7.1.0 (nf-core#4888)
4164c7d 
* Update antismash, add working stub nf-test

* First attempt to fix assertions

* Complete main.nf.test (assertions for normal test run)

* Fix linting

* Fix linting

* Fix input for antismash and version for stub test

* Fix paths + version

* Update snapshot
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
@jasmezz @jennylsmith
Update antismash/antismashlite to 7.1.0 (nf-core#4888)
b0ce1ee 
* Update antismash, add working stub nf-test

* First attempt to fix assertions

* Complete main.nf.test (assertions for normal test run)

* Fix linting

* Fix linting

* Fix input for antismash and version for stub test

* Fix paths + version

* Update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfy133 jfy133 jfy133 approved these changes

@koenbossers koenbossers Awaiting requested review from koenbossers koenbossers was automatically assigned from nf-core/nf-test

Assignees
No one assigned
Labels
update module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmezz @jfy133