Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tximport module (port from rnaseq) #4884

Merged
merged 12 commits into from
Feb 8, 2024
Merged

Conversation

pinin4fjords
Copy link
Member

@pinin4fjords pinin4fjords commented Feb 7, 2024

nf-core/test-datasets#1088 needs to be merged first, and test data link corrected here.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
    • PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware

@pinin4fjords pinin4fjords requested a review from a team as a code owner February 7, 2024 18:44
@pinin4fjords pinin4fjords requested review from LeuThrAsp and removed request for a team February 7, 2024 18:44
@pinin4fjords pinin4fjords changed the title Add tximport module Add tximport module (port from rnaseq) Feb 7, 2024
@pinin4fjords pinin4fjords marked this pull request as draft February 7, 2024 18:45
@pinin4fjords pinin4fjords marked this pull request as ready for review February 8, 2024 12:02
@pinin4fjords pinin4fjords added this pull request to the merge queue Feb 8, 2024
Merged via the queue into master with commit 0c75b48 Feb 8, 2024
11 checks passed
@pinin4fjords pinin4fjords deleted the tximeta/tximport branch February 8, 2024 15:25
read_transcript_info <- function(tinfo_path){
info <- file.info(tinfo_path)
if (info\$size == 0) {
stop("tx2gene file is empty")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I learnt about stop in R!

@@ -0,0 +1,227 @@
#!/usr/bin/env Rscript
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need --vanilla?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly. I'm mucking about with the three related r modules right now, I'll add it in another PR

jch-13 pushed a commit to jch-13/modules that referenced this pull request Mar 19, 2024
* Add tximport module

* Populate meta

* Fix up tximport

* Appease eclint

* Fix conda

* Fix singularity

* Update test_data.config

* poke ci

* remove rogue empty line

* Update tests/config/test_data.config

Co-authored-by: Maxime U Garcia <[email protected]>

---------

Co-authored-by: Maxime U Garcia <[email protected]>
jennylsmith pushed a commit to RSC-RP/modules that referenced this pull request Mar 20, 2024
* Add tximport module

* Populate meta

* Fix up tximport

* Appease eclint

* Fix conda

* Fix singularity

* Update test_data.config

* poke ci

* remove rogue empty line

* Update tests/config/test_data.config

Co-authored-by: Maxime U Garcia <[email protected]>

---------

Co-authored-by: Maxime U Garcia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants