-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding seqkit concat #4841
Adding seqkit concat #4841
Conversation
Ok, it looks like concat will produce the file of the concatenated results like it should. However, they will not be in any particular order from run to run. Need to swap the md5sum to a file contains assertion. |
https://bioinf.shenwei.me/seqkit/usage/
Wonder if this is also true for
|
Ah the docs, would have made sense if I read those too. Thanks for confirming what I thought. |
Co-authored-by: Maxime U Garcia <[email protected]>
Co-authored-by: Sateesh_Peri <[email protected]>
Sorry, a little fast on the commit suggestion button! Mistaked this open pull request for my own 😬 |
Co-authored-by: Sateesh_Peri <[email protected]>
Co-authored-by: Sateesh_Peri <[email protected]>
No worries, just means you're a maintainer now too |
""" | ||
|
||
stub: | ||
def args = task.ext.args ?: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove def args
in stub if it is not used. Actually I don't know if there is a recommendation, but it saves 1 line of code 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the other hand, it keeps it a bit more similar to the normal test. So whichever is fine, I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be fair, in my other modules, I have only kept prefixes because they are actually used. So removing it is good for consistency at least? Like you said it is a waste line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do the same for my modules ;) So feel free to update that and then ready to merge 🚀
Remove unnecessary args assignment for stub
* Adding seqkit concat * Prettier * Updates * Update format * Correct md5sum * Updated to 2.7.0, further attempts to get it working * Corrected tests * Corrected tests * Corrected tests * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Maxime U Garcia <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Updating Snapshot * Update main.nf Remove unnecessary args assignment for stub --------- Co-authored-by: Maxime U Garcia <[email protected]> Co-authored-by: Michael L Heuer <[email protected]> Co-authored-by: Sateesh_Peri <[email protected]>
* Adding seqkit concat * Prettier * Updates * Update format * Correct md5sum * Updated to 2.7.0, further attempts to get it working * Corrected tests * Corrected tests * Corrected tests * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Maxime U Garcia <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Update modules/nf-core/seqkit/concat/tests/main.nf.test Co-authored-by: Sateesh_Peri <[email protected]> * Updating Snapshot * Update main.nf Remove unnecessary args assignment for stub --------- Co-authored-by: Maxime U Garcia <[email protected]> Co-authored-by: Michael L Heuer <[email protected]> Co-authored-by: Sateesh_Peri <[email protected]>
Adding the seqkit concat command.
PR checklist
Closes #XXX
versions.yml
file.label
PROFILE=docker pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=singularity pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware
PROFILE=conda pytest --tag <MODULE> --symlink --keep-workflow-wd --git-aware