Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: One changes job to rule them all #4284

Closed
wants to merge 1 commit into from
Closed

ci: One changes job to rule them all #4284

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 11 additions & 18 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,33 +51,26 @@ jobs:
- name: Run ECLint check
run: editorconfig-checker -exclude README.md $(git ls-files | grep -v test)

pytest-changes:
name: pytest-changes
changes:
name: changes
runs-on: self-hosted
outputs:
# Expose matched filters as job 'modules' output variable
modules: ${{ steps.filter.outputs.changes }}
pytest_modules: ${{ steps.pytest-filter.outputs.changes }}
nftest_modules: ${{ steps.nftest-filter.outputs.changes }}
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 2 # To retrieve the preceding commit.

# TODO: change back to using dorny/paths-filter when https://github.com/dorny/paths-filter/pull/133 is implemented
- uses: mirpedrol/paths-filter@main
id: filter
id: pytest-filter
with:
filters: "tests/config/pytest_modules.yml"
token: ""

nf-test-changes:
name: nf-test-changes
runs-on: ubuntu-latest
outputs:
# Expose matched filters as job 'modules' output variable
modules: ${{ steps.filter.outputs.changes }}
steps:
- uses: actions/checkout@v4

## nf-test
- name: Combine all tags.yml files
id: get_tags
run: find . -name "tags.yml" -not -path "./.github/*" -exec cat {} + > .github/tags.yml
Expand All @@ -87,7 +80,7 @@ jobs:

# TODO: change back to using dorny/paths-filter when https://github.com/dorny/paths-filter/pull/133 is implemented
- uses: frouioui/paths-filter@main
id: filter
id: nftest-filter
with:
filters: ".github/tags.yml"
token: ""
Expand Down Expand Up @@ -148,8 +141,8 @@ jobs:
pytest:
runs-on: ubuntu-latest
name: pytest
needs: [pytest-changes]
if: needs.pytest-changes.outputs.modules != '[]'
needs: [changes]
if: needs.changes.outputs.pytest_modules != '[]'
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -417,8 +410,8 @@ jobs:
nf-test:
runs-on: ubuntu-latest
name: nf-test
needs: [nf-test-changes]
if: needs.nf-test-changes.outputs.modules != '[]'
needs: [changes]
if: needs.changes.outputs.nftest_modules != '[]'
strategy:
fail-fast: false
matrix:
Expand Down