Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct meta for depth plot input #521

Closed
wants to merge 2 commits into from
Closed

Use correct meta for depth plot input #521

wants to merge 2 commits into from

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Oct 4, 2023 •
edited
Loading

The wrong meta was specified after the combine, so the input to MAG_DEPTHS_PLOT had the reduced joining-'key' meta , not with the domain info

closes #518

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions
Copy link

github-actions bot commented Oct 4, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 8f98aa8

+| ✅ 158 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Remove this line if you don't need a FASTA file [TODO: try and test using for --host_fasta and --host_genome]
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in WorkflowMag.groovy: Optionally add in-text citation tools to this list.

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.10
  • Run at 2023-10-06 12:19:41

prototaxites
prototaxites approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but taking on trust that this works as I don't have time to test currently 😅

@jfy133
Copy link
Member Author

jfy133 commented Oct 4, 2023

I've tested don't worry! The comment above actually described what we wanted to do, so this was the intention regardless

@jfy133
Copy link
Member Author

jfy133 commented Oct 4, 2023

Ugh ok so I did test it but apparently in the comparison run got the parameter wrong, so not ready yet.

@jfy133 jfy133 closed this Oct 6, 2023
@jfy133 jfy133 mentioned this pull request Oct 6, 2023
Merged
10 tasks
@jfy133 jfy133 deleted the fix-depths-plot-filenames branch October 9, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prototaxites prototaxites prototaxites approved these changes

@d4straub d4straub Awaiting requested review from d4straub

Assignees

@CarsonJM CarsonJM

Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfy133 @prototaxites @CarsonJM