Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix meta map stability #480

Merged
merged 4 commits into from
Jul 24, 2023
Merged

Fix meta map stability #480

merged 4 commits into from
Jul 24, 2023

Conversation

jfy133
Copy link
Member

@jfy133 jfy133 commented Jul 20, 2023

closes #479

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs- [ ] If necessary, also make a PR on the nf-core/mag branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@jfy133 jfy133 marked this pull request as draft July 20, 2023 10:56
@github-actions
Copy link

github-actions bot commented Jul 20, 2023 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit cb3cd17

+| ✅ 156 tests passed       |+
#| ❔   1 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline

❔ Tests ignored:

  • files_unchanged - File ignored due to lint config: lib/NfcoreTemplate.groovy

✅ Tests passed:

Run details

  • nf-core/tools version 2.9
  • Run at 2023-07-24 08:03:37

@jfy133 jfy133 marked this pull request as ready for review July 21, 2023 19:01
prototaxites
prototaxites reviewed Jul 24, 2023
View reviewed changes
workflows/mag.nf Outdated
@@ -519,8 +515,7 @@ workflow MAG {
MEGAHIT ( ch_short_reads_grouped )
ch_megahit_assemblies = MEGAHIT.out.assembly
.map { meta, assembly ->
def meta_new = meta.clone()
meta_new.assembler = "MEGAHIT"
def meta_new = meta + [assember: 'MEGAHIT']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found your bug - 'assember' 😁

jfy133
jfy133 commented Jul 24, 2023
View reviewed changes
workflows/mag.nf Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
prototaxites
prototaxites approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jfy133 jfy133 merged commit 52b978f into dev Jul 24, 2023
15 checks passed
@jfy133 jfy133 deleted the fix-metamap-inconsistency branch July 24, 2023 11:24
@jfy133 jfy133 mentioned this pull request Aug 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prototaxites prototaxites prototaxites approved these changes

@d4straub d4straub Awaiting requested review from d4straub

@sateeshperi sateeshperi Awaiting requested review from sateeshperi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfy133 @prototaxites