Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update detect-nf-test-changes to v0.0.3 #307

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Update detect-nf-test-changes to v0.0.3 #307

merged 4 commits into from
Apr 30, 2024

Conversation

adamrtalbot
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/fetchngs branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 23, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 2c49a44

+| ✅ 155 tests passed       |+
#| ❔   5 tests were ignored |#
!| ❗   4 tests had warnings |!

❗ Test warnings:

  • files_exist - File not found: assets/multiqc_config.yml
  • files_exist - File not found: conf/igenomes.config
  • files_exist - File not found: .github/workflows/awstest.yml
  • files_exist - File not found: .github/workflows/awsfulltest.yml

❔ Tests ignored:

  • files_exist - File is ignored: conf/modules.config
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • actions_ci - actions_ci
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/fetchngs/fetchngs/.github/workflows/awstest.yml
  • multiqc_config - 'assets/multiqc_config.yml' not found

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-24 16:40:04

@adamrtalbot adamrtalbot marked this pull request as draft April 24, 2024 09:38
@adamrtalbot adamrtalbot changed the title Update detect-nf-test-changes to v0.0.2 Update detect-nf-test-changes to v0.0.3 Apr 24, 2024
adamrtalbot
adamrtalbot commented Apr 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
adamrtalbot
adamrtalbot commented Apr 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
adamrtalbot
adamrtalbot commented Apr 24, 2024
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@adamrtalbot adamrtalbot marked this pull request as ready for review April 30, 2024 14:30
@adamrtalbot adamrtalbot merged commit 92e9cdc into nf-core:dev Apr 30, 2024
63 checks passed
@adamrtalbot adamrtalbot deleted the bump_detect-nf-test-changes_to_v0.0.2 branch April 30, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxulysse maxulysse maxulysse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamrtalbot @maxulysse