Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gisaid/21L: Use only the 21L sequence from references #1154

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Sep 26, 2024

Description of proposed changes

data/references_sequences.fasta contains both Wuhan/Hu-1/2019 and 21L. The aligned input is expected to contain Wuhan/Hu-1/2019 so the merging with references_sequences.fasta is really only for 21L.

Related issue(s)

Fixes #1153

Checklist

  • Tested locally with a dummy file for input.aligned
  • Trial build is successful
  • Update docs/src/reference/change_log.md in this pull request to document these changes by the date they were added. not necessary - changes are within a Nextstrain profile

@victorlin victorlin self-assigned this Sep 26, 2024
@victorlin
Copy link
Member Author

Trial build was successful (gisaid/21L/global/all-time). Will rebase and merge.

data/references_sequences.fasta contains both `Wuhan/Hu-1/2019` and
`21L`. The aligned input is expected to contain `Wuhan/Hu-1/2019` so the
merging with references_sequences.fasta is really only for 21L.
@victorlin victorlin force-pushed the victorlin/fix-gisaid-21L-sequence-duplicate branch from 5729977 to 567279a Compare October 1, 2024 19:52
@victorlin victorlin merged commit bc7652a into master Oct 1, 2024
6 of 7 checks passed
@victorlin victorlin deleted the victorlin/fix-gisaid-21L-sequence-duplicate branch October 1, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gisaid/21L builds failing on duplicate sequences
2 participants