feat(ci): Use cached ncbi dataset package to isolate tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corneliusroemer
force-pushed
the
test-data
branch
from
3e5530f
to
5ff7889
Compare
corneliusroemer
force-pushed
the
test-data
branch
from
5ff7889
to
567bccf
Compare
Keeps the default rules simpler by hiding the use of example data in the custom rules for CI. This matches how we manage example data in the phylogenetic workflow.
|
Thanks @corneliusroemer, I added b9386ad to match how we manage CI's example data in phylogenetic. |
|
Nice, makes sense to do it this way, keeps the test code out of the main workflow! |
|
Merging per consensus in yesterday's dev chat:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #46, see that issue for motivation
The zip file is 8MB which is ok. If we wanted to use less space, we could turn the package into a
.tar.zstwhich uses only1.4MB.The pattern of not calling datasets in CI could be copied to other repos and/or the template if it's something we feel is useful.