Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pad out page footer #41

Merged
merged 2 commits into from
Jun 29, 2024
Merged

Pad out page footer #41

merged 2 commits into from
Jun 29, 2024

Conversation

kimandrews
Copy link
Contributor

@kimandrews kimandrews commented Jun 28, 2024

Description of proposed changes

Adds more info to the page footer, modeled after what is currently done for mpox

  • Copies description.md from mpox
  • Makes measles-specific changes to description.md and adds this info to the page footer

Addresses #37

Related issue(s)

#37

Checklist

  • Checks pass

Copied `description.md` from mpox: https://github.com/nextstrain/mpox/blob/33ba684ad243b0d823f174542e109c11282cd56b/phylogenetic/defaults/description.md

Subsequent commits will make measles-specific changes to this file
@kimandrews
Copy link
Contributor Author

kimandrews commented Jun 28, 2024

Screen shot of the page footer:

image

Modified `description.md` with measles-specific changes and added this info to the page footer of the tree.
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to say this PR doesn't completely resolve #37 because of the separate byline request. However, the byline has already been added in #39 🎉

@trvrb
Copy link
Member

trvrb commented Jun 28, 2024

This looks great to me @kimandrews. Can merge now and adjust "Reusing code and images" later depending on consensus.

@kimandrews kimandrews merged commit 9a8cf43 into main Jun 29, 2024
32 checks passed
@kimandrews kimandrews deleted the pad-out-page-footer branch June 29, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants