phylogenetic: Use inline root sequence #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimandrews
approved these changes
Apr 16, 2024
joverlee521
force-pushed
the
fix-all-input
branch
from
502a3b4
to
2d49dcb
Compare
joverlee521
changed the title
Based on feedback from @jameshadfield in nextstrain/zika#56 (comment) Looking at the existing dataset files on S3, the 8 KiB root-sequence.json is pretty negligible when the main Auspice JSON is only 163 KiB. Nextstrain datasets are limited by the 500MB memory cap in Chrome,¹ so we'd be fine adding the root sequence inline. This ensures that our uploads will include the root sequence so that they don't get out-of-sync with the main Auspice JSON. ¹ nextstrain/auspice#1622
joverlee521
force-pushed
the
fix-all-input
branch
from
2d49dcb
to
a9b3033
Compare
|
Sorry to switch it up on you @kimandrews! I just pushed up new changes to make the root sequence inline so that we no longer have to worry about the root-sequence.json file. |
|
Merging since the CI run's outputs include root_sequence in the Auspice JSONs and the datasets looks good in auspice.us |
|
Manually deleted cache and triggered a re-run of the ingest-to-phylo workflow. Once complete
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Explicitly state that the root-sequence.json file is an expected output of the core phylogenetic workflow.This also ensures that the Nextstrain automation ruledeploy_allwill include the root-sequence.json in the upload.Based on feedback from @jameshadfield in
nextstrain/zika#56 (comment)
Looking at the existing dataset files on S3,
the 8 KiB root-sequence.json is pretty negligible when the main
Auspice JSON is only 163 KiB. Nextstrain datasets are limited by the
500MB memory cap in Chrome,¹ so we'd be fine adding the
root sequence inline.
This ensures that our uploads will include the root sequence so that
they don't get out-of-sync with the main Auspice JSON.
¹ nextstrain/auspice#1622
Related issue(s)
Follow up to #21
Similar to nextstrain/zika#56
Checklist