dev: Routinely check that the latest* package is initially installable… #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test run: https://github.com/nextstrain/conda-base/actions/runs/6202996684 However, this as-is right now tests only that there exists some package version that's initially installable. It doesn't guarantee that package version is the latest. We could do that two ways:
I think (2) makes the most sense. In the meantime, testing that any version is installable is still useful, and when we update Nextstrain CLI for (2) this workflow will start always testing the latest version. |
tsibley
added a commit
to nextstrain/cli
that referenced
this pull request
Sep 15, 2023
This our intent and expectation, and it's good to be explicit about it.
It may surface more installation issues, such as the one we observed in
monkeypox CI¹ with the latest version not being installable, but
obscuring those or surfacing them later on is _probably_ worse than
addressing them head on earlier. This change will mean that any macOS
10.14 users, if any, would have to use
NEXTSTRAIN_CONDA_BASE_PACKAGE="nextstrain-base ==20230615T171309Z"
since newer versions aren't installable for them.²
This behaviour also parallels update's behaviour since "runner.conda:
Explicitly specify a nextstrain-base version when updating" (d6e4f2b).
It was an oversight (on my part) to not use the same behaviour during
setup, but at the time I was focused on fixing an update bug.
Related-to: <nextstrain/conda-base#41>
Related-to: <nextstrain/conda-base#42>
¹ <nextstrain/mpox#177>
² <nextstrain/conda-base#38>
1 task
tsibley
force-pushed
the
trs/test-installation-regularly
branch
from
e2091c6
to
c74a4a3
Compare
tsibley
changed the title
victorlin
approved these changes
Oct 3, 2023
There was a problem hiding this comment.
Commit message can be updated now that nextstrain/cli#312 is merged.
…to catch issues like the one in monkeypox CI¹ earlier. Since successful installation relies on external resources out of our control, we want to regularly test it to ensure we know when an external change breaks it. Resolves <#41>. ¹ e.g. <nextstrain/mpox#177>
tsibley
force-pushed
the
trs/test-installation-regularly
branch
from
c74a4a3
to
a64df84
Compare
|
Updated. Test run worked. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to catch issues like the one in monkeypox CI¹ earlier. Since
successful installation relies on external resources out of our control,
we want to regularly test it to ensure we know when an external change
breaks it.
* As it stands currently, this isn't strictly the latest package, just
that there's some package version that's installable. To ensure
the former, we'd have to query the latest version (e.g. similar to
what devel/download-latest does) and pass it into setup-nextstrain-cli
as an input, which would then pass it to
nextstraininNEXTSTRAIN_CONDA_BASE_PACKAGE.
Alternatively, we're likely to update
nextstrain setup condaanywayto query and install the latest version itself explicitly, just like
nextstrain update condadoes, and so this workflow can simply waitfor that change to happen.
Resolves #41.
¹ e.g. nextstrain/mpox#177
Checklist