🐞 pifs: align with Node.js v12

packages/pifs/readme.md

@@ -2,7 +2,7 @@
 
 Promisified [graceful-fs](https://github.com/isaacs/node-graceful-fs).
 
-* aligned with Node.js v10
+* aligned with Node.js v12
 * native `util.promisify()`
 * no sync methods
 * no deprecated methods like `exists`

packages/pifs/src/index.ts

@@ -24,7 +24,9 @@ export const lstat = promisify(fs.lstat)
 export const mkdir = promisify(fs.mkdir)
 export const mkdtemp = promisify(fs.mkdtemp)
 export const open = promisify(fs.open)
+export const opendir = promisify(fs.opendir)
 export const read = promisify(fs.read)
+export const readv = promisify(fs.readv)
 export const readdir = promisify(fs.readdir)
 export const readFile = promisify(fs.readFile)
 export const readlink = promisify(fs.readlink)
@@ -40,7 +42,9 @@ export const utimes = promisify(fs.utimes)
 export const watch = fs.watch
 export const watchFile = fs.watchFile
 export const write = promisify(fs.write)
+export const writev = promisify(fs.writev)
 export const writeFile = promisify(fs.writeFile)
+export const Dir = fs.Dir
 export const Dirent = fs.Dirent
 export const Stats = fs.Stats
 export const ReadStream = fs.ReadStream
@@ -70,7 +74,9 @@ export default {
   mkdir,
   mkdtemp,
   open,
+  opendir,
   read,
+  readv,
   readdir,
   readFile,
   readlink,
@@ -86,7 +92,9 @@ export default {
   watch,
   watchFile,
   write,
+  writev,
   writeFile,
+  Dir,
   Dirent,
   Stats,
   ReadStream,

packages/pifs/test/index.ts

@@ -1,83 +1,25 @@
 import test from 'tape'
 
-if (process.version.startsWith('v12')) {
-  test('pifs: exports aligned with v10', async (t) => {
-    const originalFs = await import('fs')
-    const pifs = await import('../src')
-    let hasErrors = false
-
-    for (const name of Object.keys(pifs)) {
-      if (name !== 'default' && !Reflect.has(originalFs, name)) {
-        hasErrors = true
-        t.fail(`${name} doesn't exist in Node v12`)
-      }
-    }
-
-    for (const name of Object.keys(pifs.default)) {
-      if (name !== 'default' && !Reflect.has(originalFs.default, name)) {
-        hasErrors = true
-        t.fail(`default.${name} doesn't exist in Node v12`)
-      }
-    }
-
-    if (!hasErrors) {
-      t.pass('should align exported names')
-    }
-  })
-}
-
-if (process.version.startsWith('v10')) {
-  test('pifs: align exports with Node v10', async (t) => {
-    const originalFs = await import('fs')
-    const pifs = await import('../src')
-
-    const namesToIgnore = [
-      'default',
-      'exists',
-      'promises',
-      '_toUnixTimestamp',
-      'gracefulify',
-      'FileReadStream',
-      'FileWriteStream',
-      'F_OK',
-      'R_OK',
-      'W_OK',
-      'X_OK',
-    ]
-    let hasErrors = false
-
-    const names = Object.keys(originalFs)
-      .filter((name) => !name.endsWith('Sync'))
-      .filter((name) => !namesToIgnore.includes(name))
-
-    for (const name of names) {
-      if (!Reflect.has(pifs, name)) {
-        hasErrors = true
-        t.fail(`${name} is missing`)
-      }
-
-      if (!Reflect.has(pifs.default, name)) {
-        hasErrors = true
-        t.fail(`default.${name} is missing`)
-      }
+test('pifs: exports aligned with v12', async (t) => {
+  const originalFs = await import('fs')
+  const pifs = await import('../src')
+  let hasErrors = false
+
+  for (const name of Object.keys(pifs)) {
+    if (name !== 'default' && !Reflect.has(originalFs, name)) {
+      hasErrors = true
+      t.fail(`${name} doesn't exist`)
     }
+  }
 
-    for (const name of Object.keys(pifs)) {
-      if (name !== 'default' && !Reflect.has(originalFs, name)) {
-        hasErrors = true
-        t.fail(`${name} is unknown`)
-      }
+  for (const name of Object.keys(pifs.default)) {
+    if (name !== 'default' && !Reflect.has(originalFs.default, name)) {
+      hasErrors = true
+      t.fail(`default.${name} doesn't exist`)
     }
+  }
 
-    for (const name of Object.keys(pifs.default)) {
-      if (!Reflect.has(originalFs.default, name)) {
-        hasErrors = true
-        t.fail(`default.${name} is unknown`)
-      }
-    }
-
-    if (!hasErrors) {
-      t.pass('should align exported names')
-    }
-  })
-}
+  if (!hasErrors) {
+    t.pass('should align exported names')
+  }
+})