In Google Batch, install GPU drivers for GPU VMs #5406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also clean up some old logic for container options when using GPUs. These are now automatically handled by Google Cloud. Fixes nextflow-io#5372. Signed-off-by: Siddhartha Bagaria <[email protected]>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
pditommaso
reviewed
Oct 17, 2024
Comment on lines
-327
to
-337
| if( task.config.getAccelerator() ) { | ||
| final accelerator = AllocationPolicy.Accelerator.newBuilder() | ||
| .setCount( task.config.getAccelerator().getRequest() ) | ||
|
|
||
| if( task.config.getAccelerator().getType() ) | ||
| accelerator.setType( task.config.getAccelerator().getType() ) | ||
|
|
||
| instancePolicy.addAccelerators(accelerator) | ||
| instancePolicyOrTemplate.setInstallGpuDrivers(true) | ||
| } | ||
|
|
There was a problem hiding this comment.
Not sure this should be removed. Is this API still available on Google Batch ?
There was a problem hiding this comment.
It's not removed, I just moved it to be after machineType logic. That way, setting accelerators can override the installGpuDrivers field set through machineType.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also clean up some old logic for container options when using GPUs.
These are now automatically handled by Google Cloud.
Fixes #5372.
Signed-off-by: Siddhartha Bagaria [email protected]